Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peer to peer code review #11

Open
Behnam1369 opened this issue Feb 25, 2022 · 1 comment
Open

Peer to peer code review #11

Behnam1369 opened this issue Feb 25, 2022 · 1 comment

Comments

@Behnam1369
Copy link

Good job @Saadat123456

Your project looks amazing. to highlight:

  • You created a good testing environment.
  • Your code is free of linter errors.
  • You have grouped your test which increases the readability and understandability.

There are just two minor things that you can improve:
1- instead of using querySelector('#list').querySelectorAll('#li') you can use querySelectorAll('#list li') which is shorter.
2- for testing clear all completed tasks functionality, instead of checking whether your list is empty or not, you can test if there is any completed task in your list or not.

@Saadat123456
Copy link
Owner

Thanks, @Behnam1369 for spending time on my code. I would surely take these suggestions into consideration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants