Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.editorconfig change #22

Closed
pixlcrashr opened this issue Dec 19, 2017 · 3 comments
Closed

.editorconfig change #22

pixlcrashr opened this issue Dec 19, 2017 · 3 comments

Comments

@pixlcrashr
Copy link
Collaborator

Could we change the .editorconfig's SQF indents to spaces because they're better to read in code on GitHub?

@Saborknight
Copy link
Owner

Saborknight commented Dec 19, 2017

Damn, those are big. I've never noticed, I'm normally not looking at the source code on github.

There have been numerous suggestions to fix this 8 tab size deal. The easiest seems to be this comment or the comment below that one. I'm going to go the css route, I'm already using Stylish for making github nice and dark anyway.

I don't want to change the source code just because github is silly with tab sizes...

@pixlcrashr
Copy link
Collaborator Author

pixlcrashr commented Dec 19, 2017

But how come that you use tabs instead of spaces?

@Saborknight
Copy link
Owner

Saborknight commented Dec 19, 2017

To avoid user error: added spaces between indent and code, one missing space making everything go down an indent without looking like it did. I've seen in the past a lot of code ill formatted because of this. The mistakes are so small that the developer (me included a few times when working on a space indented project) just misses them.

It also makes more sense to me... a single entity for a single purpose: a single indent.

I am aware that it's a lot of personal preference as well, but personal preference is a silly argument to make in the realms of developing in a team.

If I am wrong, I'm open to discussion, but those are what I've rationalised about the matter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants