Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request] Read executable date from logs, if available #626

Closed
mnadareski opened this issue Jan 12, 2024 · 2 comments · Fixed by #639
Closed

[Request] Read executable date from logs, if available #626

mnadareski opened this issue Jan 12, 2024 · 2 comments · Fixed by #639
Assignees
Labels
enhancement New feature or request

Comments

@mnadareski
Copy link
Collaborator

In a long-standing complaint from a subset of moderators, the current MPF code takes executable dates for PS1 and PS2 directly from the executables themselves, adjusting to UTC to account for international dumpers. Previously, dumpers have used a combination of local datetimes (as seen in whatever timezone they are in) or from the logs provided by the dumping programs.

This request covers trying to read those executable dates from the provided logs as a primary source, falling back on the UTC date if either the date in the logs is invalid or the logs do not contain a date at all. This should help some of the confusion and frustration that the original change to UTC brought.

@mnadareski mnadareski added the enhancement New feature or request label Jan 12, 2024
@mnadareski mnadareski self-assigned this Jan 12, 2024
@Deterous
Copy link
Collaborator

What systems should this apply to? There are a lot of systems that have exe or build date in redump.
MPF currently does at least PSX/PS2/KP2/GDROM/SEGACD/SATURN

@mnadareski
Copy link
Collaborator Author

Preferably all of the ones that look at a physical file for the date. At the very least that's PSX, PS2, and KP2. I believe the others come from internal values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants