ClientBuilder

[jpochyla]

Hi! I'd like to have an option to customize the reqwest::Client for explicit proxy setup, and thought that it might be a good time to add a builder for the Client fields. And while I'm at it, changing Client::credentials to be somehow optional (either through an Option or turning it into enum) would be great as well, as I'm currently just passing empty strings for the credential values and it seems wrong :) Unfortunately it's not backwards-compatible change. What do you think?

[SabrinaJewson]

I like the ClientBuilder idea! I'll implement that.

I don't want to make credentials an Option or an enum because for most use cases, it's not optional. I'm starting to think that a TokenSource trait would be the best option.

[jpochyla]

I like the ClientBuilder idea! I'll implement that.

I'm actually on it already! I'll push a writable PR.

I don't want to make credentials an Option or an enum because for most use cases, it's not optional. I'm starting to think that a TokenSource trait would be the best option.

👍