Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various improvements #7

Merged

Conversation

d4r1091
Copy link

@d4r1091 d4r1091 commented Aug 30, 2020

CachyKit will now support:

  • URLRequest with additional headers and other settings. Previously was only referring to a new URLRequest created inside the load method getting its url even though the load method was accepting a urlRequest as a parameter.
  • Archiving now works correctly after supporting optional secure coding for disk saving
  • configure method is now accessible outside of the CachyKit pod and is now matching the documentation
  • Code documentation improved
  • Readme updated

@Sadmansamee
Copy link
Owner

@d4r1091 merged

@Sadmansamee Sadmansamee merged commit 889fede into Sadmansamee:master Sep 1, 2020
@d4r1091
Copy link
Author

d4r1091 commented Sep 1, 2020

Thanks, @Sadmansamee 🙌 - I believe those changes are quite crucial to the make CachyKit fully usable with func configure and all the improvements - can you please push a new release with these changes? So that users won't need to specify the :branch => master in Podfile.

Will open an issue to make it relevant and have it addressed properly.

@d4r1091 d4r1091 deleted the fix/configure-func-and-request branch September 1, 2020 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants