Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to Zerion / Refactor logic & UI #31

Merged
merged 25 commits into from
Jan 5, 2022

Conversation

bejitono
Copy link
Collaborator

@bejitono bejitono commented Jan 3, 2022

This PR replaces Umarshal with Zerion and refactors business logic & UI for transaction history.

It does so by:

  • Removing Transaction Group models used for demo purposes and defining a new Transaction Activity model.
  • Replacing Unmarshal Client with Zerion Client.
  • Implements view mapping logic (show appropriate asset based on tx type, currency/date formatting, etc.)
  • Updates views based on latest designs. Adds a basic detail screen to inspect the tx on Etherscan.

Motivations for switching to Zerion:

  • It gives us more granular details about assets being swapped, price in fiat terms, nft assets, etc. Umarshal was too basic for our needs (only a description along with Eth value)
  • Zerion has almost everything you’d want to arrive at feature parity with other wallets (for some tx's it even provides you with tx inputs, e.g. for ENS registrations). Since it provides most of what we need it will allow us to experiment with new features quickly until we have our own proper input decoding.
  • It will be a good benchmark for our own tx categorization.

simulator_screenshot_CCDB7EAD-027D-4788-9633-A9BF7FAFA3EB

Notes: You need to apply to get a Zerion api key (https://help.zerion.io/en/articles/5351183-how-can-i-get-a-zerion-api-key). I applied for a key to be used in the test flight app. Use the demo api key for testing purposes: Demo.ukEVQp6L5vfgxcz4sBke7XvS873GMYHy

@ronaldmannak ronaldmannak merged commit fe344ea into Safari-Wallet:main Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants