WalletManager refactor #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into feature/eth_call
# Conflicts: # Shared (App and Extension)/WalletManager+Core.swift # Shared (App and Extension)/WalletManager.swift # Shared (App)/DeveloperTab/DeveloperView.swift # Shared (App)/Shared (Extension)/Resources/background.js # Shared (App)/Shared (Extension)/Resources/content.js # Shared (App)/Shared (Extension)/Resources/ethereum/dist.js # Shared (App)/Shared (Extension)/Resources/ethereum/dist.js.map # Shared (App)/Shared (Extension)/Resources/ethereum/index.js # Shared (App)/Shared (Extension)/Resources/popup.js # Shared (App)/TransactionsTab/TransactionsView.swift # Wallet.xcodeproj/project.pbxproj # Wallet.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Deploying with
|
| Latest commit: |
08115c4
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://b31380e0.ui-eff.pages.dev |
# Conflicts: # Wallet.xcodeproj/project.pbxproj
merge `feature/indie-logger` into `develop`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a big one. WalletManager is completely refactored and renamed to UserSettings for better SwiftUI support. There are still a few issues in SettingsView and signing I will need to fix in the next few days.
I've cleaned up project file and it can be merged without any issues.
The code changes are quite big. If anyone has questions, I'm happy to walk anyone through the changes in a Zoom call.
WARNING: BACK UP YOUR KEYS BEFORE USING THIS VERSION
Both the address storage and HDWallet storage formats have changed in this version. If you use a specific dev wallet, you will have to restore your wallet. Otherwise, simply create new keys.
WARNING: Running the unit tests removes all wallets