Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: infer schema of row if not passed explicitly #134

Merged
merged 5 commits into from
Mar 31, 2023

Conversation

lars-reimann
Copy link
Member

@lars-reimann lars-reimann commented Mar 31, 2023

Closes #15.

Summary of Changes

The schema parameter of the Row initializer is now optional. If it's not passed explicitly, it gets inferred from the data. The column names are set to column_0, column_1, etc.

test: restructure `Row` tests

test: additional tests for `Row`

test: fix broken test
@lars-reimann lars-reimann requested a review from a team as a code owner March 31, 2023 16:48
@lars-reimann lars-reimann linked an issue Mar 31, 2023 that may be closed by this pull request
@lars-reimann
Copy link
Member Author

lars-reimann commented Mar 31, 2023

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON black 4 0 0 0.97s
✅ PYTHON flake8 4 0 0.5s
✅ PYTHON isort 4 0 0 0.28s
✅ PYTHON mypy 4 0 2.14s
✅ PYTHON pylint 4 0 2.79s
✅ REPOSITORY git_diff yes no 0.03s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@lars-reimann lars-reimann force-pushed the 15-make-schema-parameter-of-rows-optional branch from abe2a94 to a3b2d7c Compare March 31, 2023 16:51
@codecov
Copy link

codecov bot commented Mar 31, 2023

Codecov Report

Merging #134 (9d255fb) into main (1419d25) will increase coverage by 0.33%.
The diff coverage is 86.90%.

@@            Coverage Diff             @@
##             main     #134      +/-   ##
==========================================
+ Coverage   94.16%   94.49%   +0.33%     
==========================================
  Files          36       36              
  Lines        1336     1345       +9     
==========================================
+ Hits         1258     1271      +13     
+ Misses         78       74       -4     
Impacted Files Coverage Δ
src/safeds/data/tabular/containers/_row.py 81.35% <78.12%> (+9.35%) ⬆️
src/safeds/data/tabular/containers/_column.py 90.14% <91.30%> (ø)
...rc/safeds/data/tabular/containers/_tagged_table.py 72.22% <100.00%> (ø)

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@lars-reimann lars-reimann force-pushed the 15-make-schema-parameter-of-rows-optional branch from ff63109 to 5509829 Compare March 31, 2023 16:57
@lars-reimann lars-reimann merged commit c5869bb into main Mar 31, 2023
@lars-reimann lars-reimann deleted the 15-make-schema-parameter-of-rows-optional branch March 31, 2023 17:02
lars-reimann pushed a commit that referenced this pull request Mar 31, 2023
## [0.8.0](v0.7.0...v0.8.0) (2023-03-31)

### Features

* create empty `Table` without schema ([#128](#128)) ([ddd3f59](ddd3f59)), closes [#127](#127)
* improve `ColumnType`s ([#132](#132)) ([1786a87](1786a87)), closes [#113](#113)
* infer schema of row if not passed explicitly ([#134](#134)) ([c5869bb](c5869bb)), closes [#15](#15)
* new method `is_fitted` to check whether a model is fitted ([#130](#130)) ([8e1c3ea](8e1c3ea))
* new method `is_fitted` to check whether a transformer is fitted ([#131](#131)) ([e20954f](e20954f))
* rename `drop_XY` methods of `Table` to `remove_XY` ([#122](#122)) ([98d76a4](98d76a4))
* rename `fit_transform` to `fit_and_transform` ([#119](#119)) ([76a7112](76a7112)), closes [#112](#112)
* rename `shuffle` to `shuffle_rows` ([#125](#125)) ([ea21928](ea21928))
* rename `slice` to `slice_rows` ([#126](#126)) ([20d21c2](20d21c2))
* rename `TableSchema` to `Schema` ([#133](#133)) ([1419d25](1419d25))
@lars-reimann
Copy link
Member Author

🎉 This PR is included in version 0.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lars-reimann lars-reimann added the released Included in a release label Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Included in a release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make schema parameter of Rows optional
1 participant