Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable copy-on-write for pandas dataframes #494

Merged
merged 5 commits into from
Nov 16, 2023
Merged

Conversation

lars-reimann
Copy link
Member

@lars-reimann lars-reimann commented Nov 16, 2023

Closes #428

Summary of Changes

  • Enable copy-on-write for Pandas dataframes. This will be enabled in Pandas v3 by default.
  • Remove unnecessary cloning.

@lars-reimann lars-reimann requested a review from a team as a code owner November 16, 2023 13:49
Copy link
Contributor

github-actions bot commented Nov 16, 2023

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON black 5 0 0 0.85s
✅ PYTHON mypy 5 0 1.77s
✅ PYTHON ruff 5 0 0 0.08s
✅ REPOSITORY git_diff yes no 0.11s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

Copy link

codecov bot commented Nov 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5bf0e75) 100.00% compared to head (f35d14b) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #494   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           49        49           
  Lines         2713      2702   -11     
=========================================
- Hits          2713      2702   -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lars-reimann lars-reimann marked this pull request as draft November 16, 2023 13:51
@lars-reimann lars-reimann marked this pull request as ready for review November 16, 2023 14:50
@lars-reimann lars-reimann merged commit 9a19389 into main Nov 16, 2023
10 of 11 checks passed
@lars-reimann lars-reimann deleted the pandas-cow branch November 16, 2023 14:52
lars-reimann added a commit that referenced this pull request Nov 16, 2023
### Summary of Changes

#494 enabled Pandas's copy-on-write feature. This PR removes the
explicit deep copies that were created in table transformers.

---------

Co-authored-by: megalinter-bot <129584137+megalinter-bot@users.noreply.github.com>
lars-reimann pushed a commit that referenced this pull request Nov 22, 2023
## [0.16.0](v0.15.0...v0.16.0) (2023-11-22)

### Features

* drop Python 3.10 and add Python 3.12 ([#478](#478)) ([5bf0e75](5bf0e75))
* enable copy-on-write for pandas dataframes ([#494](#494)) ([9a19389](9a19389)), closes [#428](#428)

### Bug Fixes

* **deps-dev:** Bump urllib3 from 1.26.17 to 1.26.18 ([#480](#480)) ([a592d2c](a592d2c)), closes [#3159](https://github.com/Safe-DS/Library/issues/3159)

### Performance Improvements

* remove unneeded copy operations in table transformers ([#496](#496)) ([6443beb](6443beb)), closes [#494](#494)
@lars-reimann
Copy link
Member Author

🎉 This PR is included in version 0.16.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lars-reimann lars-reimann added the released Included in a release label Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Included in a release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unnecessary cloning
2 participants