Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ARIMA model #577

Merged
merged 68 commits into from
Apr 9, 2024
Merged

feat: add ARIMA model #577

merged 68 commits into from
Apr 9, 2024

Conversation

Gerhardsa0
Copy link
Contributor

@Gerhardsa0 Gerhardsa0 commented Mar 19, 2024

Closes #570

Summary of Changes

  • added time_series_from_csv to TimeSeries-class.
  • added split_rows to TimeSeries-class.
  • added ArimaModel
  • added compare_timeseries to TimeSeries-class.

You can see test workflow on the test function test_arima_model()

EXPERIMENTAL
arima works
gotta fix time series bug first
…at-add-arima-model

# Conflicts:
#	poetry.lock
#	pyproject.toml
added correction of dtypes for empty columns in time series

They are now always type object! This was caused by the get_column method, so maybe we have an more occuring error with pandas dtypes with empty columns.
@Gerhardsa0 Gerhardsa0 requested a review from a team as a code owner March 19, 2024 13:18
@Gerhardsa0 Gerhardsa0 linked an issue Mar 19, 2024 that may be closed by this pull request
Copy link
Contributor

github-actions bot commented Mar 19, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON black 11 0 0 0.92s
✅ PYTHON mypy 11 0 2.12s
✅ PYTHON ruff 11 0 0 0.16s
✅ REPOSITORY git_diff yes no 0.15s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@lars-reimann lars-reimann marked this pull request as draft March 20, 2024 16:30
Copy link

codecov bot commented Mar 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (ffb8304) to head (0d5196f).

Additional details and impacted files
@@            Coverage Diff             @@
##              main      #577    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           53        54     +1     
  Lines         3212      3323   +111     
==========================================
+ Hits          3212      3323   +111     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Gerhardsa0 and others added 9 commits April 2, 2024 16:02
Co-authored-by: Alexander <47296670+Marsmaennchen221@users.noreply.github.com>
Co-authored-by: Alexander <47296670+Marsmaennchen221@users.noreply.github.com>
Co-authored-by: Alexander <47296670+Marsmaennchen221@users.noreply.github.com>
Co-authored-by: Alexander <47296670+Marsmaennchen221@users.noreply.github.com>
Co-authored-by: Alexander <47296670+Marsmaennchen221@users.noreply.github.com>
Co-authored-by: Alexander <47296670+Marsmaennchen221@users.noreply.github.com>
src/safeds/data/tabular/containers/_time_series.py Outdated Show resolved Hide resolved
src/safeds/data/tabular/containers/_time_series.py Outdated Show resolved Hide resolved
src/safeds/data/tabular/containers/_time_series.py Outdated Show resolved Hide resolved
src/safeds/data/tabular/containers/_time_series.py Outdated Show resolved Hide resolved
src/safeds/data/tabular/containers/_time_series.py Outdated Show resolved Hide resolved
src/safeds/data/tabular/containers/_time_series.py Outdated Show resolved Hide resolved
src/safeds/ml/classical/regression/_arima.py Outdated Show resolved Hide resolved
src/safeds/ml/classical/regression/_arima.py Show resolved Hide resolved
src/safeds/ml/classical/regression/_arima.py Outdated Show resolved Hide resolved
Gerhardsa0 and others added 5 commits April 8, 2024 12:34
added doc changes

Co-authored-by: Alexander <47296670+Marsmaennchen221@users.noreply.github.com>
Co-authored-by: Alexander <47296670+Marsmaennchen221@users.noreply.github.com>
Co-authored-by: Alexander <47296670+Marsmaennchen221@users.noreply.github.com>
Co-authored-by: Alexander <47296670+Marsmaennchen221@users.noreply.github.com>
@Marsmaennchen221
Copy link
Contributor

@lars-reimann your approval is needed for changes to poetry.lock and pyproject.toml

@lars-reimann lars-reimann merged commit 8b9c7a9 into main Apr 9, 2024
8 checks passed
@lars-reimann lars-reimann deleted the 570-feat-add-arima-model branch April 9, 2024 10:03
lars-reimann pushed a commit that referenced this pull request Apr 17, 2024
## [0.21.0](v0.20.0...v0.21.0) (2024-04-17)

### Features

* add ARIMA model ([#577](#577)) ([8b9c7a9](8b9c7a9)), closes [#570](#570)
* Add ImageList class ([#534](#534)) ([3cb74a2](3cb74a2)), closes [#528](#528) [#599](#599) [#600](#600)
* more hash, sizeof and eq implementations ([#609](#609)) ([2bc0b0a](2bc0b0a))

### Performance Improvements

* Add special case to `Table.add_rows` to increase performance ([#608](#608)) ([ffb8304](ffb8304)), closes [#606](#606)
* improve performance of model & forward layer ([#616](#616)) ([e856cd5](e856cd5)), closes [#610](#610)
* lazily import our modules and external libraries ([#624](#624)) ([20fc313](20fc313))
* treat Tables specially when calling add_rows ([#606](#606)) ([e555b85](e555b85)), closes [#575](#575)
@lars-reimann
Copy link
Member

🎉 This PR is included in version 0.21.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lars-reimann lars-reimann added the released Included in a release label Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Included in a release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Add ARIMA Model
5 participants