Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: move plotting methods into Column and Table classes #88

Merged
merged 4 commits into from
Mar 26, 2023

Conversation

lars-reimann
Copy link
Member

Closes #62.

Summary of Changes

  • Move plotting methods into Column and Table classes since they are specific to these classes. We don't want to create a generic plotting library.
  • Remove the plotting module.

@lars-reimann lars-reimann linked an issue Mar 26, 2023 that may be closed by this pull request
@lars-reimann
Copy link
Member Author

lars-reimann commented Mar 26, 2023

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON black 7 0 0 1.09s
✅ PYTHON flake8 7 0 0.65s
✅ PYTHON isort 7 0 0 0.32s
✅ PYTHON mypy 7 0 2.65s
✅ PYTHON pylint 7 0 4.19s
✅ REPOSITORY git_diff yes no 0.03s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@codecov
Copy link

codecov bot commented Mar 26, 2023

Codecov Report

Merging #88 (6b371ef) into main (15999b5) will decrease coverage by 0.15%.
The diff coverage is 94.00%.

❗ Current head 6b371ef differs from pull request most recent head 74e6c71. Consider uploading reports for the commit 74e6c71 to get more accurate results

@@            Coverage Diff             @@
##             main      #88      +/-   ##
==========================================
- Coverage   91.68%   91.53%   -0.15%     
==========================================
  Files          42       36       -6     
  Lines        1154     1134      -20     
==========================================
- Hits         1058     1038      -20     
  Misses         96       96              
Impacted Files Coverage Δ
src/safeds/data/tabular/containers/_table.py 91.48% <93.54%> (+0.22%) ⬆️
src/safeds/data/tabular/containers/_column.py 90.14% <94.73%> (+0.70%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@lars-reimann lars-reimann merged commit 5ec6189 into main Mar 26, 2023
@lars-reimann lars-reimann deleted the 62-restructure-plotting-methods branch March 26, 2023 20:02
lars-reimann pushed a commit that referenced this pull request Mar 26, 2023
## [0.5.0](v0.4.0...v0.5.0) (2023-03-26)

### Features

* move plotting methods into `Column` and `Table` classes ([#88](#88)) ([5ec6189](5ec6189)), closes [#62](#62)
@lars-reimann
Copy link
Member Author

🎉 This PR is included in version 0.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lars-reimann lars-reimann added the released Included in a release label Mar 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Included in a release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restructure plotting methods
1 participant