fix: Fixed bugs for analyzing packages and api data creation. #27

Masara · 2023-10-23T13:11:36Z

Summary of Changes

Fixed a bug in _get_api.py which prevented analyzing packages with different path lengths.
Fixed a bug in _ast_visitor.py for the api data creation, in which the id of modules did not correctly represent their path.
Adjusted test snapshots

…fferent path lengths. Fixed a bug _ast_visitor.py for the api data creation, in which the id of modules did not correctly represent their path.

codecov · 2023-10-23T13:13:06Z

Codecov Report

Merging #27 (2a8e11c) into main (0651f5b) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #27      +/-   ##
==========================================
+ Coverage   96.72%   96.74%   +0.02%     
==========================================
  Files          24       24              
  Lines        1344     1353       +9     
==========================================
+ Hits         1300     1309       +9     
  Misses         44       44

Files	Coverage Δ
src/safeds_stubgen/api_analyzer/_ast_visitor.py	`95.33% <100.00%> (+0.14%)`	⬆️
src/safeds_stubgen/api_analyzer/_get_api.py	`98.33% <100.00%> (ø)`

…butes that have the same name as the source package

…to fixes-path_lengths-module_id

tests/safeds_stubgen/__snapshots__/test_main.ambr

tests/data/test_package/test_package/test_package.py

src/safeds_stubgen/api_analyzer/_ast_visitor.py

Masara · 2023-11-10T09:35:41Z

@lars-reimann Everything should be okay now, I don't know how to resolve the changes requests though. Could you review and merge once again?

## [0.1.0](v0.0.1...v0.1.0) (2023-11-29) ### Features * drop Python 3.10 and add Python 3.12 ([#23](#23)) ([091826d](091826d)) * port code from `library-analyzer` ([#16](#16)) ([5e0b3b1](5e0b3b1)) ### Bug Fixes * Added handling for boolean default values for parameters ([#25](#25)) ([1ff250d](1ff250d)) * **deps-dev:** bump urllib3 from 2.0.6 to 2.0.7 ([#26](#26)) ([ff1a33b](ff1a33b)), closes [#3144](https://github.com/Safe-DS/Stub-Generator/issues/3144) * Fixed bugs for analyzing packages and api data creation. ([#27](#27)) ([80215a3](80215a3))

lars-reimann · 2023-11-29T10:21:49Z

🎉 This PR is included in version 0.1.0 🎉

The release is available on:

v0.1.0
GitHub release

Your semantic-release bot 📦🚀

Bumps [mkdocs-glightbox](https://github.com/Blueswen/mkdocs-glightbox) from 0.3.6 to 0.3.7. <details> <summary>Release notes</summary> Sourced from <a href="https://github.com/Blueswen/mkdocs-glightbox/releases">mkdocs-glightbox's releases</a>. <blockquote> <h2>mkdocs-glightbox-0.3.7</h2> <ul> <li>Supported custom background and shadow (<a href="https://redirect.github.com/Blueswen/mkdocs-glightbox/issues/27">#27</a>)</li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> Sourced from <a href="https://github.com/blueswen/mkdocs-glightbox/blob/main/CHANGELOG">mkdocs-glightbox's changelog</a>. <blockquote> mkdocs-glightbox-0.3.7 (2023-01-24) <pre><code>* Supported custom background and shadow ([#27](blueswen/mkdocs-glightbox#27)) </code></pre> mkdocs-glightbox-0.3.6 (2023-12-30) <pre><code>* Modified width default to auto prevent zooming large image bug ([#21](blueswen/mkdocs-glightbox#21)) * Supported only enable glightbox with on-glb class in given page ([#28](blueswen/mkdocs-glightbox#28)) </code></pre> mkdocs-glightbox-0.3.5 (2023-11-18) <pre><code>* Supported compatibility with the privacy plugin of Material for MkDocs insiders ([#25](blueswen/mkdocs-glightbox#25)) </code></pre> mkdocs-glightbox-0.3.4 (2023-04-25) <pre><code>* Fixed regex bug: quote issue and empty alt issue ([#14](blueswen/mkdocs-glightbox#14) [#19](blueswen/mkdocs-glightbox#19)) </code></pre> mkdocs-glightbox-0.3.3 (2023-04-20) <pre><code>* Refactored processing logic with regex ([#14](blueswen/mkdocs-glightbox#14)) </code></pre> mkdocs-glightbox-0.3.2 (2023-03-19) <pre><code>* Supported image without extension ([#13](blueswen/mkdocs-glightbox#13)) </code></pre> mkdocs-glightbox-0.3.1 (2022-11-22) <pre><code>* Supported lightbox slide effect customization ([#8](blueswen/mkdocs-glightbox#8)) * Supported synchronized lightbox caption dark mode with Material for MkDocs ([#7](blueswen/mkdocs-glightbox#7)) * Supported glightbox built-in gallery feature ([#11](blueswen/mkdocs-glightbox#11)) * Supported skip image in the anchor tag </code></pre> mkdocs-glightbox-0.3.0 (2022-09-29) <pre><code>* Fixed width and height setting in config not working bug * Supported specific skip class ([#5](blueswen/mkdocs-glightbox#5)) * Supported glightbox built-in caption with title and description ([#4](blueswen/mkdocs-glightbox#4)) * Fixed page jitter when lightbox closing issue using Material for MkDocs * Add white background for lightbox images to prevent the displaying issue of the transparent image on black background </code></pre> mkdocs-glightbox-0.2.1 (2022-08-10) <pre><code>* Updated readme </code></pre> mkdocs-glightbox-0.2.0 (2022-08-10) <pre><code>* Added support for disabling glightbox with image class or page meta ([#2](blueswen/mkdocs-glightbox#2)) </code></pre> mkdocs-glightbox-0.1.7 (2022-07-26)  </blockquote> ... (truncated) </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/blueswen/mkdocs-glightbox/commit/1f086123bdda7214961e4df4494edd253b8ee9e2"><code>1f08612</code></a> Support custom background and shadow (<a href="https://redirect.github.com/Blueswen/mkdocs-glightbox/issues/27">#27</a>)</li> <li><a href="https://github.com/blueswen/mkdocs-glightbox/commit/bbe99498a936ba6292854b0886a48a608aacf5d6"><code>bbe9949</code></a> Update docs</li> <li>See full diff in <a href="https://github.com/Blueswen/mkdocs-glightbox/compare/v0.3.6...v0.3.7">compare view</a></li> </ul> </details> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=mkdocs-glightbox&package-manager=pip&previous-version=0.3.6&new-version=0.3.7)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Fixed a bug in _get_api.py which prevented analysing packages with di…

5e51e2e

…fferent path lengths. Fixed a bug _ast_visitor.py for the api data creation, in which the id of modules did not correctly represent their path.

megalinter-bot and others added 4 commits October 23, 2023 13:14

style: apply automated linter fixes

3a61470

Added test cases for files, directories, classes, functions and attri…

3d8aee4

…butes that have the same name as the source package

Merge remote-tracking branch 'origin/fixes-path_lengths-module_id' in…

7201cda

…to fixes-path_lengths-module_id

linter fix

7f4dd64

Masara marked this pull request as ready for review October 26, 2023 13:55

Masara requested a review from a team as a code owner October 26, 2023 13:55

lars-reimann requested changes Oct 26, 2023

View reviewed changes

Masara and others added 4 commits November 6, 2023 15:35

Merge branch 'main' into fixes-path_lengths-module_id

979fd9c

Refactoring

2becc96

Refactoring, removing some snapshot tests and adding unit tests instead

ffe6a98

style: apply automated linter fixes

2a8e11c

lars-reimann approved these changes Nov 10, 2023

View reviewed changes

lars-reimann merged commit 80215a3 into main Nov 10, 2023
8 checks passed

lars-reimann deleted the fixes-path_lengths-module_id branch November 10, 2023 20:29

lars-reimann added the released Included in a release label Nov 29, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Fixed bugs for analyzing packages and api data creation. #27

fix: Fixed bugs for analyzing packages and api data creation. #27

Masara commented Oct 23, 2023 •

edited by lars-reimann

codecov bot commented Oct 23, 2023 •

edited

Masara commented Nov 10, 2023

lars-reimann commented Nov 29, 2023

fix: Fixed bugs for analyzing packages and api data creation. #27

fix: Fixed bugs for analyzing packages and api data creation. #27

Conversation

Masara commented Oct 23, 2023 • edited by lars-reimann

Summary of Changes

codecov bot commented Oct 23, 2023 • edited

Codecov Report

Masara commented Nov 10, 2023

lars-reimann commented Nov 29, 2023

Masara commented Oct 23, 2023 •

edited by lars-reimann

codecov bot commented Oct 23, 2023 •

edited