Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firmware releases and build instructions are missing #1

Open
xrviv opened this issue Jan 22, 2024 · 16 comments
Open

Firmware releases and build instructions are missing #1

xrviv opened this issue Jan 22, 2024 · 16 comments

Comments

@xrviv
Copy link

xrviv commented Jan 22, 2024

Hello!

Fellow bitcoiner. We are a bitcoin project at walletscrutiny.com that looks into source-available Bitcoin apps and wallets. We found that the SafePalX1 does not have the following:

  1. Build instructions
  2. Release/Tags

We would like to invite you to kindly include this. It would help us re-build if possible from the source code and then conduct verification procedures.

We appreciate your response!

@spiros3p
Copy link

hi, as a buyer of the X1 and S1, that requests sounds awesome.
I am really looking forward for more eyes to have a look at the source code of these devices before I can safely recommend them to my friends and fmaily

@adam22adee
Copy link

I too am a buyer of the X1. I would be very pleased if you could publish what wallet scrutiny is asking for. I trust their opinion and I am sure many other people would purchase the X1 if it received a 12/12 score on
https://walletscrutiny.com/

@daic11
Copy link

daic11 commented Feb 26, 2024

I also confirm that the build is impossible due to the lack of the MAKEFILE.
There are also no instruction about the enviroment variables/docker container required to make build possible.
Please update the repo with the building instruction. It looks like a random folder from the desktop:)

Hope you will update the repo thank you!

P.S.: there is a lack of coin management in your last 1.0.5 firmware version. You can't remove addresses/coins that you added through the Safepal app. So please modify. There are also bluetooth connection problems with IOS (it connects randomly).

Thank you.

@stevexyz
Copy link

Hello!

Fellow bitcoiner. We are a bitcoin project at walletscrutiny.com that looks into source-available Bitcoin apps and wallets. We found that the SafePalX1 does not have the following:

1. Build instructions

2. Release/Tags

We would like to invite you to kindly include this. It would help us re-build if possible from the source code and then conduct verification procedures.

We appreciate your response!

@xrviv what confirms you that this account and repositories are managed by the real producer (safepal) of the device? (I didn't find any link on their website, but maybe I missed it)

the (little) activity present here seems not consistent/coherent to the claims of the real company, or at least suspicious

@xrviv
Copy link
Author

xrviv commented Apr 11, 2024

Fair point @stevexyz. I will investigate further.

@xrviv
Copy link
Author

xrviv commented Apr 11, 2024

@xrviv what confirms you that this account and repositories are managed by the real producer (safepal) of the device? (I didn't find any link on their website, but maybe I missed it)

the (little) activity present here seems not consistent/coherent to the claims of the real company, or at least suspicious

Here are some links, mostly from their blog:

Digging deeper into some history, it appears that they've went from not source-available to source-available and perhaps, back again.

https://www.reddit.com/r/safePal/comments/klvzmb/any_chance_safepal_will_go_open_source/

Given that its firmware upgrades continue on, up to March 21, 2024, and because this is not reflected in this repository, I would have to change our assessment to "not source-available" on walletscrutiny.com

@daic11
Copy link

daic11 commented Apr 11, 2024

Given that its firmware upgrades continue on, up to March 21, 2024, and because this is not reflected in this repository, I would have to change our assessment to "not source-available" on walletscrutiny.com

Why they advertise themself as an "The first open-source bluetooth hardware wallet by SafePal" so they misleading their customers. People could buy their product based on this advert. Their app is closed-source, the firmware is closed-source.

Why do they do this to their customers and do they have the right to do it?

@stevexyz
Copy link

Crypto is all about removing "trust" from the equation. Closed sources are taking it back in. But the behaviour of this company doesn't seem to scream for it.

@Keeqler
Copy link

Keeqler commented Apr 11, 2024

@hwdev-safepal @SafePalWallet I hope you're not pretending you can't see this.

@xrviv
Copy link
Author

xrviv commented Apr 12, 2024

Given that its firmware upgrades continue on, up to March 21, 2024, and because this is not reflected in this repository, I would have to change our assessment to "not source-available" on walletscrutiny.com

Why they advertise themself as an "The first open-source bluetooth hardware wallet by SafePal" so they misleading their customers. People could buy their product based on this advert. Their app is closed-source, the firmware is closed-source.

Why do they do this to their customers and do they have the right to do it?

If you are an owner of the device, it would help others by sharing your opinion on walletscrutiny.com.

The url for the safepalx1 is https://walletscrutiny.com/hardware/safepalx1/

@Giszmo
Copy link

Giszmo commented Apr 12, 2024

@Keeqler I had worked for a bitcoin wallet as the maintainer and the public repo was very much an afterthought. We updated it with the releases but didn't look much into the issue tracker. That said, it's not trust inducing to do so.

@daic11
Copy link

daic11 commented Apr 12, 2024

@Keeqler I had worked for a bitcoin wallet as the maintainer and the public repo was very much an afterthought. We updated it with the releases but didn't look much into the issue tracker. That said, it's not trust inducing to do so.

Yeah, they just ignore issues, lol :)

@Gabrieltk5
Copy link

Great job you are doing guys. Hope soon the company will fix this issues and make X1 model open source code again.
I asked SafePal about this issues via

https://safepalsupport.zendesk.com/hc/en-us/requests/new?ticket_form_id=360001760732

And they answered me in 1 day the following:

“Thank you very much for reaching out to SafePal!
These infos should be updated soon on github.
Appreciate your understanding and patience dear user.
Best regards,
Jack
SafePal Support Team”

I think it would be good if everyone uses this channel to ask for fixing this issues, so they will be aware of the problem and stop just ignoring.

@Gabrieltk5
Copy link

There was a firmware update uploaded 2 days ago.

@daic11
Copy link

daic11 commented Apr 15, 2024

There was a firmware update uploaded 2 days ago.

Yeah but still no instructions how to build hehe

@xrviv
Copy link
Author

xrviv commented Apr 16, 2024

There was a firmware update uploaded 2 days ago.

It would be helpful if they could provide the necessary build instructions. At walletscrutiny.com, we encounter several frameworks, which can get quite complicated since there are more than 6000+ bitcoin android apps and several hundreds of hardware devices.

We would appreciate this, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants