2to3

[adrinjalali]

Hey,

Not sure why your code is not compatible with python3. Anyway I ported it mostly using 2to3, and some manual changes, and tested some basic features like login, and get.

I'll be using python3, and will try to fix issues if I encounter any.

Cheers,
Adrin.

[larssono]

Thanks you adrinjalali that is awesome! Will review and test. Unfortunately it doesn't seem to be backwards compatible with 2.7 anymore. This would require us to keep two codebases or include try/excepts around incompatible code. Do you have experience with maintaining both 2 and 3 codebases uptodate?

[adrinjalali]

No I don't have "ANY" experience maintaining any python code supporting 2 and 3.

But with the last commit ("2 and 3") I somehow managed to have it working under both pythons, and try/excepts are added only to import sections. The rest of the code seems working for me, but I'll be happy to help if there is something not working.

[cbare]

Nice work! We appreciate the contribution as "look into Python 3 compatibility" has been on the to-do list for some time.

[adrinjalali]

You're welcome! Please note that 2to3 has removed some of the Exception messages. It's not ready for a release; but any tests will be appreciated.

As I'm not very familiar with all capabilities of this package, I can't tell if there are any problems with usual use-cases of the package.

[larssono]

We have a pretty good test suite with 85%+ coverage. Currently the 2to3 pull request fails on the first test using Python2.7. You can use nose to run the tests using your python3 install.

[adrinjalali]

I'll appreciate if somebody gives me a hand on this.

[cbare]

This pull-request is being closed in favor of moving Python3 compatibility work to the python3 branch (see PR#256).

Thank you for the contribution. It took way too long, but this work will be merged into the main line of development after a period of testing.