Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename the 'name' to 'cognito_idp' (Use underscore instead of hyphen), easier connect with Rails/Devise #8

Open
ash-r1 opened this issue Sep 11, 2020 · 0 comments

Comments

@ash-r1
Copy link

ash-r1 commented Sep 11, 2020

I'm using this gem with devise-omniauthable on Ruby on Rails. It implicitly uses its name option field in rails routing.

I have to configure with like below:

config.omniauth :cognito_idp,
  name: :cognito_idp,
  # other options

I know it's not bad of omniauth-cognito-idp, it's just a compatibility issue. They can also fix this issue.
But it might not cause any problem for Sinatra users, also I believe I achieve benefits for Rails users, please consider this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant