Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peer-to-peer morning review #14

Closed
Yothu opened this issue Jan 21, 2022 · 1 comment
Closed

Peer-to-peer morning review #14

Yothu opened this issue Jan 21, 2022 · 1 comment

Comments

@Yothu
Copy link

Yothu commented Jan 21, 2022

I would recommend putting more detail into what the test actually does, for example:

test('Delete a task', () => {
removeTask(0);
const list = document.querySelectorAll('.listItem');
expect(list).toHaveLength(0);
});

Here the test is actually testing if the task list length is 0, and that implies that the task was deleted, it is necessary to make the description test a statement as objective as possible, in this particular test I would recommend The length of the task list that has a task inside it after removing a task is 0, in the suggestion I describe the start of the test and the expected result of the test.
The same issue can be found in every test.

@Sahar-AbdelSamad
Copy link
Owner

Well noted. Thank you 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants