Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rideable is installed and enabled in my world, but it does not work, and does not show up in Configure Settings #19

Open
devteamplus opened this issue Jul 24, 2023 · 10 comments
Labels
bug Something isn't working probably/partially fixed

Comments

@devteamplus
Copy link

devteamplus commented Jul 24, 2023

I just recently updated to your latest version (2.4.2) of the module. Now, my tokens no longer have the ability to mount, unmount, or be ridden. I removed and reinstalled the module. However, it shows up in the main Foundry module list as not installed, even though when I click on "Install" it brings up a notice that it was installed.

Rideable does not appear in the list under "Configure Settings" either.

I tried to run "Find the Culprit", but Rideable does not appear on the list of available modules to keep enabled.

FYI - Foundry v 11.306

@Saibot393
Copy link
Owner

Could you try deleting the module folder manually (Foundry data folder>modules>Rideable) and then reinstalling it.
Also, do you know which Rideable version you had installed before the update?

@Saibot393 Saibot393 added the bug Something isn't working label Jul 24, 2023
@Saibot393
Copy link
Owner

Another thing, when you install it while having the console open (F12), do any errors show up?

@Saibot393
Copy link
Owner

I may have found the cause of this Problem. I have rereleased v2.4.2. with an appropiate bug fix

@devteamplus
Copy link
Author

Sorry, had to jump into a meeting.

So, the only thing I did was uninstall and reinstall. And here are the results:

  • The module still shows (in the main Foundry listing) as not being installed.
  • Mounting and unmounting works as expected.
  • Rideable appears in the "Configure Settings" options now.
  • When trying to use "Find the Culprit", Rideable does NOT appear on the list of modules available to start with as enabled.

Hope this helps. And, you may want to make this 2.4.3, so that Foundry will recognize that and update, as expected.

@Saibot393
Copy link
Owner

Saibot393 commented Jul 24, 2023

Ok, at least the module works now in principle, thank you for the confirmation.
The first problem is actually something that was (as far as im aware) present since v1.0.0. I have a few ideas why this is happening, but since it doesn't cause any problems and the testing for it could be quite annoying i will leave it alone for now and focus on additional features.
The "Find the Culprit" thing however is strange, especially since it shows up for me. I will leave the issue open until i find out what causes that. I would be quite grateful if you could inform me here, should Rideable show up in "Find the Culprit" in a future update.

@devteamplus
Copy link
Author

Sure... you bet. I'll keep an eye on it and let you know if it returns to the list.

Thanks.

@devteamplus
Copy link
Author

Also, thought you'd like to know that "Lock and Key" is exhibiting the same behavior in that it does not show as "installed" after a successful install. It DOES appear in the list of modules that can be enabled/disabled. And, it DOES appear in the list of "Configure Settings". It DOES NOT appear in the list of modules in "Find the Culprit".

Thought you'd like to know.

@Saibot393
Copy link
Owner

Thanks for letting me know. I assume that it will be same problem, so at least i can solve both at the same time, as soon as i discover the reason for this behaviour.

@Saibot393
Copy link
Owner

Saibot393 commented Jul 26, 2023

I think i found the reason for both problems (at least for the showing as not installed bug). The problem is, that i use an upper case "Rideable" as the module ID, while Foundry only allows for lowercase IDs for their website IDs. Therefore foundry finds "rideable" on the website, which is technically not installed, but will install "Rideable". I can not simply change my internal ID to a lowercase since that will erase all settings any user ever made in Rideable which will probably be a bit annoying for many people. There may be some way around this by changing the on website ID. The Module "Material Deck" for example did this, so maybe there is a way. For now i will leave it as it is, since the solution could bring further (more devastating) bugs.

@devteamplus
Copy link
Author

Agreed. Yeah, that sounds like a logical reason for the issue. Can live with it. They work - so no need to upset the apple cart at this point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working probably/partially fixed
Projects
None yet
Development

No branches or pull requests

2 participants