Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set elevation of Riders #31

Open
OmegaRogue opened this issue Aug 31, 2023 · 10 comments
Open

Set elevation of Riders #31

OmegaRogue opened this issue Aug 31, 2023 · 10 comments
Labels
bug Something isn't working

Comments

@OmegaRogue
Copy link

As an Improvement on #27, it would be cool if the module would also set the actual elevation of the rider to that height

@Saibot393
Copy link
Owner

Saibot393 commented Aug 31, 2023

I am not quite sure what you mean. Currently the module should set the riders elevation to the ridden tokens elevation + the ridden tokens riding height (if set, the one configured in the token settings). Or do you mean the Wall-Height/Levels elevation?

@Saibot393 Saibot393 added the enhancement New feature or request label Aug 31, 2023
@OmegaRogue
Copy link
Author

Those are the same elevation, and it seems like it doesnt set it, until you mount another token, then the previously mounted tokens get their elevation set, but as soon as the mount moves, the elevation gets reset back to 0

@Saibot393
Copy link
Owner

So when you set a Custom riding height, the mounted tokens elevation gets set to zero once you move the mount? If so, that is bug, probably caused by an incompatibility with another module. Does it also happen when no other modules are active? If not, what other modules are you using?

@OmegaRogue
Copy link
Author

Ok, i did two find the culprit, both came out with blaming incorrect modules, but i did some manual testing, and it seems it elevated vision setting the tokens back to ground height

@Saibot393 Saibot393 added bug Something isn't working and removed enhancement New feature or request labels Sep 1, 2023
@Saibot393
Copy link
Owner

Saibot393 commented Sep 1, 2023

Thanks for informing me, i will look into it and see if i can find a solution, could take a while tho since this bug will probably have to be solveed by both Rideable and elevated vision

@Saibot393
Copy link
Owner

I think this bug should be resolved with the newest version of both modules

@Saibot393
Copy link
Owner

I can no longer reproduce the bug. I will therefore assume this issue to be solved unless i hear otherwise and will probably close this issue soon.

@OmegaRogue
Copy link
Author

I can still, as long as the terrain elevation is different from 0

@Saibot393 Saibot393 reopened this Oct 23, 2023
@Saibot393
Copy link
Owner

Which version of Elevated vision are you using?

@OmegaRogue
Copy link
Author

Which version of Elevated vision are you using?

0.5.9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants