Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better EventQueue event injection support #27

Closed
SaladDais opened this issue Jun 30, 2022 · 1 comment
Closed

Better EventQueue event injection support #27

SaladDais opened this issue Jun 30, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@SaladDais
Copy link
Owner

Right now an event can only be injected when we actually receive an event over the real EQ due to how we're intercepting the response. That means injected events can be delayed by up to 30 seconds. Not nice.

It might make sense to switch to a strategy where we hold onto the flow ID for event queue requests with pending server responses and preempt the server response by injecting our own response. It's not clear to me if mitmproxy has support for closing the server half of the proxied connection for an in-flight request and injecting a response, but that's the obvious choice.
@SaladDais SaladDais added the enhancement New feature or request label Jun 30, 2022
@SaladDais
Copy link
Owner Author

Looks like supporting HTTP response preemption through mitmproxy will be non-trivial. Added a hack to allow it for EQ by sending a placesquery to trigger an EQ response whenever we inject an event: fde9ddf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@SaladDais