Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect WeightedPackageInfo parameter name #71

Closed
david-vaclavek opened this issue Sep 29, 2022 · 5 comments
Closed

Incorrect WeightedPackageInfo parameter name #71

david-vaclavek opened this issue Sep 29, 2022 · 5 comments

Comments

@david-vaclavek
Copy link

I'm using v1.3.3 for project compatibility reasons (can't use the newest version, don't have the PHP v7 support), anyway as a browse the code, the problem occurs in the newest version as well.

In Api.php file on line 475, key name should be WeightedPackageInfo instead of WeightedPackageInfoIn. I've checked it against the current WSDL version.

Currently, the WeightedPackageInfo is not sent to API at all.
When I changed it manually in my project, it worked.

Would it be possible to update the file?

Thank you.

@Salamek
Copy link
Owner

Salamek commented Sep 29, 2022

That means that wsdl spec was changed... fixed in next release...
PS: Also i would suggest to migrate your project to 7.4 (Debian stable PHP version) anything under version 7 is dead, PHP 8.1 is stable version now...

@david-vaclavek
Copy link
Author

Thanks.

I know anything under v7 is dead, but I'm just partly contributing to a project and I won't be able to persuade the owner to migrate.

Are you planning to release a patch for the package with v5 support?
Or should I make a PR?

@Salamek
Copy link
Owner

Salamek commented Sep 29, 2022

You are still using 1.3.3? That is still working?
So if i will branch of 1.3.3 and release 1.3.4 will that be ok for you?

@Salamek
Copy link
Owner

Salamek commented Sep 29, 2022

Ok version 1.3.4 should be installable now...

@david-vaclavek
Copy link
Author

Really appreciated.

Thank you for doing that!

PS: Yes, generally PHP v5 version still works well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants