Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What do you mean? Our team is concerned now #105

Closed
tieorange opened this issue May 7, 2021 · 3 comments
Closed

What do you mean? Our team is concerned now #105

tieorange opened this issue May 7, 2021 · 3 comments
Labels
question Further information is requested

Comments

@sergeykomlach
Copy link
Owner

sergeykomlach commented May 7, 2021

It's a bit outdated comment, but still can be valid - I'll check ASAP.
On 'pure' API28 implementation (built-in BiometricPrompt API) is no way to get 'isBiometricEnrolled' results for specific biometric, like Iris/Face, etc.
So, some tricks have used that try to determine by indirect signs which biometric data are used (like "if NOT fingerprint BUT something enabled in the System Settings").
There are edge cases where we cannot tell exactly what type of biometrics is registered - for example, if it is Samsung with Face and Iris - in this case, the code can give a false-positive result. It can happen if you set BiometricApi.BIOMETRIC_API + BiometricType.BIOMETRIC_FACE or BiometricApi.BIOMETRIC_API + BiometricType.BIOMETRIC_IRIS

Fortunately, for Samsung with Face and Iris, the 'legacy' check should work correctly, so for general cases when you use BiometricApi.AUTO/LEGACY_API + BiometricType.BIOMETRIC_FACE/BIOMETRIC_IRIS all should work fine.

@sergeykomlach
Copy link
Owner

I made few changes in the library, also add the new section to the README
https://github.com/Salat-Cx65/AdvancedBiometricPromptCompat#false-positive-andor-false-negative-detection

@tieorange
Copy link
Author

Thanks mate!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants