Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

One Plus 9 fingerprint unlock (Not fixed) #309

Closed
jamiehiggins opened this issue Aug 25, 2022 · 3 comments
Closed

One Plus 9 fingerprint unlock (Not fixed) #309

jamiehiggins opened this issue Aug 25, 2022 · 3 comments

Comments

@jamiehiggins
Copy link

Unfortunately #305 does not appear to be fixed when I'm importing the new version of the library.

I've dived into the code to try and work out why it was working on your APK build and the difference is as follows:

I believe you sent me a debug build and because of this the isExperimentalFeaturesEnabled flag was set to true.

This results in the following code being executed (in BiometricPrompApi28Impl):

            if (builder.isExperimentalFeaturesEnabled() && builder.getPrimaryAvailableTypes().size == 1 && builder.getPrimaryAvailableTypes()
                    .toMutableList()[0] == BiometricType.BIOMETRIC_FINGERPRINT
            ) {
                forceToFingerprint = true
            }

and the forceToFingerprint is set to true.

I am able to get it working by setting the experimental features to true when I'm calling.

sergeykomlach pushed a commit that referenced this issue Aug 26, 2022
@sergeykomlach
Copy link
Owner

Wow, you are right.
I prepare the fix and update the library.
Should work now

@sergeykomlach
Copy link
Owner

@jamiehiggins can we close the issue?

@jamiehiggins
Copy link
Author

@sergeykomlach Yep all seems good now. Thanks again for the quick fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants