Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create vendor app. #2

Merged
merged 4 commits into from
Aug 12, 2021
Merged

Create vendor app. #2

merged 4 commits into from
Aug 12, 2021

Conversation

shovan777
Copy link
Collaborator

Add Vendor models.
Set relations to user, warehouse and allocation model.

I want to discuss this change where vendor, app models and relation are created.

Impact

  • New migrations
  • New/Updated API fields or mutations
  • Deprecated API fields or mutations
  • Removed API types, fields, or mutations
  • Documentation needs to be updated

Pull Request Checklist

  • Privileged queries and mutations are guarded by proper permission checks
  • Database queries are optimized and the number of queries is constant
  • Database migration files are up to date
  • The changes are tested
  • GraphQL schema and type definitions are up to date
  • Changes are mentioned in the changelog

Add Vendor models.
Set relations to user, warehouse and allocation model.
@sushilkhadka165
Copy link
Collaborator

Detaching the warehouse from vendor model and relationing both in the new model would be nice because warehouse and vender related fields can be made there where as vendor only related fields can be used in vendor model. so rather than creating the many to many it would be nice in new model

class VendorWarehoue(models.Model): vendor = models.Foreignkey(Vendor) warehouse = models.OneToOneField(Warehouse) ......

saleor/vendor/models.py Outdated Show resolved Hide resolved
saleor/vendor/models.py Outdated Show resolved Hide resolved
@shovan777 shovan777 added this to In progress in Saleor_multivendor via automation Aug 10, 2021
@shovan777 shovan777 added the enhancement New feature or request label Aug 10, 2021
@shovan777 shovan777 moved this from In progress to Review in progress in Saleor_multivendor Aug 10, 2021
Add model for vendor's warehouse.
Add vendor relations to access vendor's warehouse.
@shovan777 shovan777 changed the base branch from master to multivendor August 11, 2021 10:51
Saleor_multivendor automation moved this from Review in progress to Reviewer approved Aug 12, 2021
@shovan777 shovan777 merged commit 2fab965 into multivendor Aug 12, 2021
Saleor_multivendor automation moved this from Reviewer approved to Done Aug 12, 2021
@shovan777 shovan777 deleted the mv_warehouse branch August 12, 2021 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants