Org Telemetry Fixes #3782
Merged
Org Telemetry Fixes #3782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tureParamter in the event of a query error as opposed to when the value should actually be zero.
…uery can run against a very very large organization without timing out. The initial query tests used two different WHERE clauses against the npe03__Recurring_Donation__c field. Both of those consistently failed with a query timeout error. The only query that did run consistently is one without any filter at all. Technically we could use a filter with against an indexed field, however in this case the goal was to use " != null" which would not use the index. As a result this job will query and loop through all Opportunity records, but just count the recurring donation related ones.
|
**lurch: attach W-029397 |
|
Tracking W-029397 |
|
**lurch: attach W-029509 |
|
Tracking W-029509 |
RadSFDeveloper
approved these changes
Nov 5, 2018
There was a problem hiding this comment.
Thank you for the through analysis of the changes @force2b !
|
Thank you @RadSFDeveloper! |
|
Free to merge after the builds are done. |
RadSFDeveloper
deleted the
feature/msmith/org-telemetry-returns-neg1-instead-of-zero
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix two issues:
UTIL_OrgTelemetry_SObject_BATCHjob after push upgrades. This PR changes the query to remove the non-selective filter against the Opportunity object. Significant query tests were done in to determine what query can run against a very very large organization without timing out. The initial query tests used two different WHERE clauses against the npe03__Recurring_Donation__c field. Both of those consistently failed with a query timeout error. The only query that did run consistently is one without any filter at all. Technically we could use a filter with against an indexed field, however in this case the goal was to use " != null" which would not use the index. As a result this job will query and loop through all Opportunity records, but just count the recurring donation related ones. Tests show that even with 16M Opportunities, this batch job will complete in under two hours (and is read-only, without any DML on any objects).Critical Changes
Changes
Issues Closed
New Metadata
Deleted Metadata