Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes for upstream #2

Merged
merged 1 commit into from May 12, 2014
Merged

Changes for upstream #2

merged 1 commit into from May 12, 2014

Conversation

ndahlquist
Copy link
Contributor

Hi Salomon!

These are our changes. We were liberal with renaming, so let me know if you would like me to revert our renames to preserve your public API. Thank you for a great library!

@SalomonBrys
Copy link
Owner

Hi,
I agree with all your changes except, in fact, the naming.
Is it possible to revert to ANRWatchDog and ANRError ?
Also, I think that ANRListener is a more comprehensive name then AnrWatchDogInterface. What do you think ?

@ndahlquist
Copy link
Contributor Author

Hi Salomon! I have updated our pull with your suggestions- please let me know if you have any others.

@SalomonBrys
Copy link
Owner

Thanks for everything.
Good to merge 👍

SalomonBrys added a commit that referenced this pull request May 12, 2014
Added the ANRListener.
Updated thread code to make it more semantic.
Updated README
@SalomonBrys SalomonBrys merged commit 0f87015 into SalomonBrys:master May 12, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants