Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to react-three-fiber #13

Closed
Abbondanzo opened this issue May 13, 2019 · 2 comments
Closed

Switch to react-three-fiber #13

Abbondanzo opened this issue May 13, 2019 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@Abbondanzo
Copy link
Member

Abbondanzo commented May 13, 2019

If we use react-three-fiber, we can eliminate several of the model loaders and managers to localize them into a single React component. This also lets us lock down certain behaviors, like attaching the camera (by passing it as a prop) amongst other cool state-based functionality that plain ol' classes do not give us.

@Abbondanzo Abbondanzo self-assigned this May 13, 2019
@Abbondanzo Abbondanzo mentioned this issue May 13, 2019
18 tasks
@Abbondanzo Abbondanzo added this to Icebox in Replay Viewer via automation May 13, 2019
@Abbondanzo Abbondanzo moved this from Icebox to In Progress in Replay Viewer May 13, 2019
@Abbondanzo Abbondanzo moved this from In Progress to Icebox in Replay Viewer May 15, 2019
@Abbondanzo Abbondanzo added enhancement New feature or request and removed todo 🗒️ labels May 15, 2019
@Abbondanzo
Copy link
Member Author

Did a bit of poking and it seems like we're going to need to do some additional setup. Going to kick this down the line until alpha is released so that we can lock down control functionality first.

@Abbondanzo
Copy link
Member Author

Closing this since it doesn't make much sense to lock us down into React

Replay Viewer automation moved this from Icebox to Done Oct 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Replay Viewer
  
Done
Development

No branches or pull requests

1 participant