Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #50 and adds various debug commands helpful for fixing issues - [merged] #103

Closed
SamB440 opened this issue May 13, 2021 · 12 comments
Closed

Comments

@SamB440
Copy link
Owner

SamB440 commented May 13, 2021

In GitLab by @JordanPlayz158 on May 13, 2021, 20:53

Merges master -> master

As stated in the title, these commits fix issue #50 and add various debug commands (/taleofkingdoms [debug] [add,get,invoke,set] [{coins, worthiness},{coins, worthiness, hasRebuilt, hasAttacked},{saveVillagers, guildAttack},{coins, worthiness}]).

@SamB440
Copy link
Owner Author

SamB440 commented May 13, 2021

Exceptions should not be generically caught

@SamB440
Copy link
Owner Author

SamB440 commented May 13, 2021

Wow, can we move all this stuff to another class? very long

@SamB440
Copy link
Owner Author

SamB440 commented May 13, 2021

@SamB440
Copy link
Owner Author

SamB440 commented May 13, 2021

In GitLab by @JordanPlayz158 on May 13, 2021, 21:52

added 1 commit

  • af0ded4 - Fixing exception to not be caught generally (Exception) but rather to be...

Compare with previous version

@SamB440
Copy link
Owner Author

SamB440 commented May 13, 2021

In GitLab by @JordanPlayz158 on May 13, 2021, 21:53

Commented on src/main/java/com/convallyria/taleofkingdoms/server/commands/debug/TaleOfKingdomsInvokeCommand.java line 43

Have fixed the issue

@SamB440
Copy link
Owner Author

SamB440 commented May 13, 2021

In GitLab by @JordanPlayz158 on May 13, 2021, 22:06

Commented on src/main/java/com/convallyria/taleofkingdoms/TaleOfKingdoms.java line 196

changed this line in version 3 of the diff

@SamB440
Copy link
Owner Author

SamB440 commented May 13, 2021

In GitLab by @JordanPlayz158 on May 13, 2021, 22:06

added 2 commits

  • 57364bb - TaleOfKingdoms.java: - Added registerCommands function to make registering...
  • cabc471 - TaleOfKingdomsCommands.java:

Compare with previous version

@SamB440
Copy link
Owner Author

SamB440 commented May 13, 2021

In GitLab by @JordanPlayz158 on May 13, 2021, 22:07

Commented on src/main/java/com/convallyria/taleofkingdoms/TaleOfKingdoms.java line 196

Done in the latest 2 commits!

@SamB440
Copy link
Owner Author

SamB440 commented May 13, 2021

In GitLab by @JordanPlayz158 on May 13, 2021, 22:23

added 1 commit

  • 312e246 - TaleOfKingdomsInvokeCommand.java:

Compare with previous version

@SamB440
Copy link
Owner Author

SamB440 commented May 13, 2021

resolved all threads

@SamB440
Copy link
Owner Author

SamB440 commented May 13, 2021

approved this merge request

@SamB440
Copy link
Owner Author

SamB440 commented May 13, 2021

mentioned in commit aeeb27b

@SamB440 SamB440 closed this as completed May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant