Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Master - [merged] #80

Closed
SamB440 opened this issue Nov 10, 2020 · 13 comments
Closed

Master - [merged] #80

SamB440 opened this issue Nov 10, 2020 · 13 comments

Comments

@SamB440
Copy link
Owner

SamB440 commented Nov 10, 2020

In GitLab by @KingCobra_200 on Nov 10, 2020, 14:21

Merges master -> master

Fully Implemented the Banker.
Checks for no coins. Message saying to slay monsters for coins.
Deposits and Withdraws with correct Exit message.

@SamB440
Copy link
Owner Author

SamB440 commented Nov 10, 2020

In GitLab by @KingCobra_200 on Nov 10, 2020, 14:46

added 7 commits

Compare with previous version

@SamB440
Copy link
Owner Author

SamB440 commented Nov 10, 2020

In GitLab by @KingCobra_200 on Nov 10, 2020, 15:16

added 3 commits

  • f72b840 - Merge branch 'master' of https://gitlab.com/SamB440/tale-of-kingdoms
  • de30b6c - Fixed banker methods.
  • da6a04a - Merge branch 'master' of https://gitlab.com/EduardoGarza00/tale-of-kingdoms

Compare with previous version

@SamB440
Copy link
Owner Author

SamB440 commented Nov 10, 2020

Please don't use brackets etc like this. https://google.github.io/styleguide/javaguide.html

@SamB440
Copy link
Owner Author

SamB440 commented Nov 10, 2020

Same as +44 to +48

@SamB440
Copy link
Owner Author

SamB440 commented Nov 10, 2020

Use the local variable instead.

@SamB440
Copy link
Owner Author

SamB440 commented Nov 10, 2020

Why?

@SamB440
Copy link
Owner Author

SamB440 commented Nov 10, 2020

In GitLab by @KingCobra_200 on Nov 10, 2020, 16:03

Commented on src/main/java/net/islandearth/taleofkingdoms/client/gui/entity/BankerScreen.java line 88

changed this line in version 4 of the diff

@SamB440
Copy link
Owner Author

SamB440 commented Nov 10, 2020

In GitLab by @KingCobra_200 on Nov 10, 2020, 16:03

Commented on src/main/java/net/islandearth/taleofkingdoms/client/gui/entity/BlacksmithScreen.java line 11

changed this line in version 4 of the diff

@SamB440
Copy link
Owner Author

SamB440 commented Nov 10, 2020

In GitLab by @KingCobra_200 on Nov 10, 2020, 16:03

added 1 commit

Compare with previous version

@SamB440
Copy link
Owner Author

SamB440 commented Nov 10, 2020

resolved all threads

@SamB440
Copy link
Owner Author

SamB440 commented Nov 10, 2020

approved this merge request

@SamB440
Copy link
Owner Author

SamB440 commented Nov 10, 2020

enabled an automatic merge when the pipeline for 8a6982d succeeds

@SamB440
Copy link
Owner Author

SamB440 commented Nov 10, 2020

mentioned in commit a48cca4

@SamB440 SamB440 closed this as completed May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant