Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sanity check graph takes a long time to load #7

Closed
matt-graham opened this issue Oct 8, 2021 · 2 comments
Closed

Sanity check graph takes a long time to load #7

matt-graham opened this issue Oct 8, 2021 · 2 comments

Comments

@matt-graham
Copy link

Submitting as part of JOSS review openjournals/joss-reviews/issues/3651

I really like the sanity check example in the documentation, however I think it may be worth using a different location than London to source the example graph as running

graph = ox.graph_from_place('London, UK')

takes around 8 minutes on my laptop and the lack of any progress updates from the osmnx package when executing graph_from_place made it a bit unclear initially if the interpreter had crashed. Swapping for a location that produces a smaller graph would still perform the same function of illustrating the inference algorithm is computing something sensible but without requiring so much patience from the user! If you prefer to keep the current example, I think it would then be worth at least putting a warning to expect the osmnx functions to take a long time to run.

@SamDuffield
Copy link
Owner

As a large portion of the anticipated use cases is in urban environments (most likely major cities such as London) I think leaving the example as is but adding a precautionary comment about osmnx loading times is the most useful for the user. (Also the sample_route function works better for larger areas as it is less likely to terminate early on reaching the edge of the area.)

I have added said warnings to the docs!

@matt-graham
Copy link
Author

As a large portion of the anticipated use cases is in urban environments (most likely major cities such as London) I think leaving the example as is but adding a precautionary comment about osmnx loading times is the most useful for the user. (Also the sample_route function works better for larger areas as it is less likely to terminate early on reaching the edge of the area.)

Those both seem good rationales for keeping the current example, thanks for the clarifications!

I have added said warnings to the docs!

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants