Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Save FIELD_BOOLEAN as byte array #65

Closed
SamVanheer opened this issue Nov 19, 2021 · 0 comments
Closed

Save FIELD_BOOLEAN as byte array #65

SamVanheer opened this issue Nov 19, 2021 · 0 comments
Assignees
@SamVanheer
Labels
enhancement New feature or request

Comments

@SamVanheer
Copy link
Collaborator

The FIELD_BOOLEAN type is currently saved as an array of integers. Save it as an array of bytes instead. This saves space in the save game, but more importantly prepares for the switch from the 4 byte BOOL type to the implementation-defined size1 bool type.

Footnotes

  1. See C++ Standard, section 5.3.3: expr.sizeof ↩
@SamVanheer SamVanheer added the enhancement New feature or request label Nov 19, 2021
@SamVanheer SamVanheer self-assigned this Nov 19, 2021
@SamVanheer SamVanheer reopened this Nov 28, 2021
LogicAndTrick pushed a commit to LogicAndTrick/halflife-updated that referenced this issue Dec 26, 2021
@SamVanheer @LogicAndTrick
Save FIELD_BOOLEAN as byte array
1d686dd 
Resolves twhl-community#65

(cherry picked from commit c147156)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SamVanheer SamVanheer

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@SamVanheer