Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve performance #6

Closed
sindresorhus opened this issue Sep 7, 2018 · 2 comments
Closed

Improve performance #6

sindresorhus opened this issue Sep 7, 2018 · 2 comments

Comments

@sindresorhus
Copy link
Collaborator

I realize this is the TS compiler being slow but is there any way we could improve the performance?

~/dev/oss/write-json-file master*
❯ time ./node_modules/.bin/tsd-check
real         1.72
user         2.47
sys          0.12

It shouldn't take 2 seconds to check a simple test file.
@StarpTech
Copy link
Contributor

StarpTech commented Sep 19, 2018 •
edited

I could reduce the time from ~2291,5909 to ~1469,8804ms with the compiler option skipLibCheck: true. Would you accept a PR?

@StarpTech
Copy link
Contributor

I could improve it further #8

@StarpTech StarpTech mentioned this issue Sep 19, 2018
Merged
SamVerschueren pushed a commit that referenced this issue Sep 23, 2018
@StarpTech @SamVerschueren
Improve performance - fixes #6 (#8)
8d2bb90
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sindresorhus @StarpTech