-
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow using relative paths for settings #105
Comments
@sindresorhus which one would you prefer? I could do a quick PR. |
I'm willing to support/merge this if you want to make a PR @flying-sheep seems like a reasonable use case to me. The only line that would need to be changed is this: I don't think we should use the same variable substitution that vscode uses, because I don't think we need to support any token other than workspace folder. Maybe a token like? A relative path would be fine too - it just needs to be clear in the docs that if you supply an absolute path it must be in file uri format and the path will always be relative to the folder root. Will need to change this as well: |
I’d prefer a relative path to a custom placeholder. The |
sounds good @flying-sheep - I will take care of this later today If I don't see a PR. |
@flying-sheep this is published now 3.7.0 - I went ahead an added a couple of lines to deprecate the file uri and made the option take an absolute path or a relative path because I felt this made more sense. Thanks for your help! |
great, thank you! |
There’s two possible ways to go about this:
./blah
relative paths in addition tofile://
URLs, or${workspaceFolder}
): Since inexplicably VS Code doesn’t export the mechanism it uses itself (Support variables when resolving values in settings microsoft/vscode#2809), we could use a subset of the code PythonVSCode usesOne step in the resolution of #71
The text was updated successfully, but these errors were encountered: