Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use inside a devcontainer is slow and do not reset errors #133

Closed
vabatta opened this issue Aug 25, 2023 · 1 comment
Closed

Use inside a devcontainer is slow and do not reset errors #133

vabatta opened this issue Aug 25, 2023 · 1 comment
Labels

Comments

@vabatta
Copy link

vabatta commented Aug 25, 2023

Using the extension inside a devcontainer is slow and do not reset errors.
With the following config

"xo": {
	"extends": "xo-react",
	"prettier": true,
	"envs": [
		"es2024",
		"webextensions",
		"browser"
	]
}

Editing a simple file (trimmed for sake of example)

return (
	<Theme>
		<Heading>
			Welcome to your{' '}
			<a href="https://www.plasmo.com" target="_blank" rel="noreferrer">
				Plasmo
			</a>{' '}
			Extension!
		</Heading>
	</Theme>
);

As soon as I delete part of </Heading>, I get the error Parsing error: Expected corresponding JSX closing tag for 'Heading'.XO but it won't reset if I complete it again. A server resets makes the error go away. (To clarify, I get the error while the code is valid)

@spence-s
Copy link
Collaborator

spence-s commented Aug 25, 2023

There isn't much we can do about performance here: try the tricks here and see if you can up your container resources or move your files inside the container.

https://code.visualstudio.com/remote/advancedcontainers/improve-performance

I personally do not use dev containers and have no interest in trying them, so I won't be testing against them, if you find something obvious that we are doing to not support them, feel free to make a PR (or send me a message, if its obvious I am willing to support it) but nothing stands out to me in the documentation.

I have never had a good experience using docker desktop or docker at all on mac so I generally avoid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants