Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linter XO ignores disable directives #72

Closed
shanoaice opened this issue Jan 9, 2020 · 6 comments
Closed

Linter XO ignores disable directives #72

shanoaice opened this issue Jan 9, 2020 · 6 comments

Comments

@shanoaice
Copy link

When I tried to disable check for a line like this:

'code with problem' // eslint-disable-line

The extension ignores the disable directive and continued to report the error

@sindresorhus
Copy link
Member

You have to specify which rule(s) to disable.

@Noctumsempra
Copy link

You have to specify which rule(s) to disable.

Nop. It should just NOT check that line.

@papb
Copy link
Contributor

papb commented Jun 22, 2020

Are you sure the linter is not reporting an abusive disable? XO has a rule that disallows using eslint-disable-line

@Noctumsempra
Copy link

The few times I've put that special comment in Webstorm to bypass some circumstantial checking, this IDE took it correctly. Given eslint directives are made to be used if needed, any JS editor/IDE should support it, imho.

@papb
Copy link
Contributor

papb commented Jun 22, 2020

@Noctumsempra Yeah, I know, I was just asking to be sure if the directive wasn't working, or the directive did work as it should and XO is now reporting another error (i.e. the fact that you're using eslint-disable-line, which by itself is an error)

@spence-s
Copy link
Collaborator

stale and likely xo issue that has been resolved by now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants