Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support XO as Transitive Dependency #84

Closed
osdevisnot opened this issue Aug 27, 2020 · 1 comment
Closed

Support XO as Transitive Dependency #84

osdevisnot opened this issue Aug 27, 2020 · 1 comment

Comments

@osdevisnot
Copy link

Hi @SamVerschueren, first of - thank you so much for your efforts on this extension.

While using this extension, I noticed we look for xo being listed as dependency in the package.json at project root to enable the linting experience.

See relevant code here and here

It might be beneficial for us to look for xo being actually installed as opposed to just being listed in package.json - for example by trying to require it or by looking at package.json under <project-root>/node_modules/xo.

This will help address issues when xo is installed in a project as a transitive dependency of some other packages.

I can also look into creating an MR for this if you think it's a good idea.

@spence-s
Copy link
Collaborator

closed by 8ca7319

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants