Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Code Linters #86

Open
PiyushRaj927 opened this issue Jun 21, 2023 · 4 comments
Open

Implement Code Linters #86

PiyushRaj927 opened this issue Jun 21, 2023 · 4 comments

Comments

@PiyushRaj927
Copy link
Collaborator

PiyushRaj927 commented Jun 21, 2023

In order to maintain consistent code quality and identify problems early on, we should incorporate a linters into our workflow. This will assist in streamlining the code review process as well.

@PiyushRaj927
Copy link
Collaborator Author

Considering https://github.com/super-linter/super-linter as it is the easiest to set up, but lacks a local version for testing changes before committing.
Should we opt for implementing individual linters for our specific needs instead ?
cc: @jayanth-kumar-morem, @singhalkarun

@ChakshuGautam
Copy link
Collaborator

Hey @PiyushRaj927 couple of things

  1. Can you list down the type of errors that you are seeing frequently? Files and line numbers would help categorize these issues.
  2. Can you share your dev environment? Are you looking for something like a cli-based linter that runs using husky pre-commit hooks?

@PiyushRaj927
Copy link
Collaborator Author

Hey @ChakshuGautam,
I haven't encountered any errors so far. Could you please provide more information about the errors you mentioned? I'm not entirely sure what you're referring to.

Regarding the development environment, I appreciate you mentioning pre-commit hooks. I wasn't familiar with them before, but they seem to be exactly what I was looking for. Additionally, incorporating a linter workflow along with the pre-hooks to validate pull requests should fulfill the requirements I had in mind.

Regarding my development environment, I'm using Windows 10 with WSL2 Ubuntu and Docker Desktop.

@Gmin2
Copy link

Gmin2 commented May 3, 2024

Hey @PiyushRaj927 can you please twell why #103 was closed, is the super-linter still needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants