New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI workflow with update #13
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for adding CI and remove not working repos.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
name: CI | ||
|
||
on: | ||
push: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also add regular rerun once every month or so
As otherwise we cannot automatically detect problems without opening a new PR
@@ -174,8 +176,6 @@ def move_files(temp_dir, dataset_dir): | |||
else: | |||
shutil.copy(license_location, f"{dataset_dir}/{new_repo_id}/{name}") | |||
|
|||
print(f"Processed: {i + 1}/{len(snapshot_data)}") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why move this print?
@@ -102,10 +102,6 @@ | |||
sha: 829cac07c8e155cc1844dc3a069dcf9283abf603 | |||
tag: None | |||
url: https://github.com/sherlock-project/sherlock | |||
- id: n2x1PPtw |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please note that it's unnecessary to remove meta of unassimilable repos after #14
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems it need to be fixed or revert..
pip install PyYAML | ||
fi | ||
|
||
python download_data.py --data_dir data |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you want user to install project using this script please mention it in the readme
If it's just for automation, than it can probably be a part of a CI job
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just CI.
Runner for the repo is not enabled
* script * xorm project removed due it is not public * erminusdb/terminusdb removed * removed two meta * test in workflow * fix * skip git api * virtualenv Co-authored-by: Roman Babenko <r.babenko@samsung.com>
Removed some non-public repositories.
Updated debug info to enlighten which repo is processing before it throws an exception.
Checks are available https://github.com/babenek/CredData/pull/1/checks