Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update download_data.py #4

Merged
merged 1 commit into from Sep 27, 2021
Merged

Update download_data.py #4

merged 1 commit into from Sep 27, 2021

Conversation

meanrin
Copy link
Contributor

@meanrin meanrin commented Sep 20, 2021

Change True to T in download script due to the changes in fc0caa5

Modified rows used to select credentials for obfuscation

csh519
csh519 approved these changes Sep 22, 2021
View reviewed changes
Copy link
Contributor

@csh519 csh519 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah.. it was missing.. Thanks for update.

LGTM 👍

silentearth
silentearth approved these changes Sep 27, 2021
View reviewed changes
Copy link
Contributor

@silentearth silentearth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing!
LGTM

@meanrin meanrin merged commit 5dc5653 into main Sep 27, 2021
@meanrin meanrin deleted the Update-download_data.py branch September 27, 2021 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silentearth silentearth silentearth approved these changes

@csh519 csh519 csh519 approved these changes

@yuzzyuzz yuzzyuzz Awaiting requested review from yuzzyuzz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@meanrin @silentearth @csh519