New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
False positive for short regular expressions #178
Comments
Both options are good. filtering_prefix = [" ", "=", ":"]
if candidate_prefix in filtering_prefix:
return True # Filtered
return False |
ML decision = 0.546 for example from http://calebb.net/ |
Adding minimal length of 12 results in fixing issue for mentioned examples without reducing metrics on the CredData |
Other related PR: #184 |
I'll close this issue as both ideas already implemented (left alphanumeric character and min length) |
Many short regular expressions may randomly apear in the hashes, or base64 lines
Example:
https://github.com/tosca/web/blob/master/packages/EntityFramework.5.0.0/tools/EntityFramework.PS3.psd1#L172
99.9% sure it's not really a JWT
While it is a JWT example, this can probably also happen with other short regular expressions (e.g. Google API based on
ya29.
prefix)As for now i see few options to solve it:
=eyJBw...
- ok,dasjkfseyJBw
- badMaybe there are some different options. Please propose if you'll have any
I haven't tested it with the CredData metrics yet, just ideas
The text was updated successfully, but these errors were encountered: