Possible error when setting model matrix

[crbozz]

GearVRf/GVRf/Framework/framework/src/main/jni/objects/components/transform.cpp

Line 151 in 79c0f3e

glm::mat3 rotation_mat(matrix[0][0] / new_scale.x,

I'm facing a problem when trying to set model matrix to a scene object and it seems the statement starting at the line above is the reason. When setting model matrix for a scene object (using setModelMatrix(Matrix4f mat)) position and scale are correct but rotation is not. I tried to calculate position, scale and rotation at Java side (using JOML) and then apply them (using Java transform API methods) and it worked fine. Then I tried to change the above statement as below and it also worked:

glm::mat3 rotation_mat(matrix[0][0] / new_scale.x, matrix[0][1] / new_scale.x, matrix[0][2] / new_scale.x, matrix[1][0] / new_scale.y, matrix[1][1] / new_scale.y, matrix[1][2] / new_scale.y, matrix[2][0] / new_scale.z, matrix[2][1] / new_scale.z, matrix[2][2] / new_scale.z);

Is this really and issue or maybe there is something else to consider when setting model matrix?

[liaxim]

Can you share code showing the problem?
Could it be a row vs column major confusion somewhere in the code?

[crbozz]

The problem was detected at the new A.R. demo we are working on: https://github.com/sidia-dev-team/GearVRf-Demos/tree/feature_arpet

More specifically in the method starting here: https://github.com/sidia-dev-team/GearVRf-Demos/blob/83a0821c57f57e9e53df07532f65dc67a3b77c25/gvr-arpet/app/src/main/java/org/gearvrf/arpet/PlaneHandler.java#L58

I replaced the call to setModelMatrix by some other operations that I supposed should have same results.

I will make some changes to this demo so that you can easily visualize the problem.

[crbozz]

I just added some "visual debug" code to the demo. Just uncomment the lines starting here:

https://github.com/sidia-dev-team/GearVRf-Demos/blob/73303d58f89212681f3f1778cb0c496cda3d7de5/gvr-arpet/app/src/main/java/org/gearvrf/arpet/PlaneHandler.java#L74

It will make a box appear on the detected plane. Then you can switch to way this box transform is updated uncommenting the two lines starting here:

https://github.com/sidia-dev-team/GearVRf-Demos/blob/73303d58f89212681f3f1778cb0c496cda3d7de5/gvr-arpet/app/src/main/java/org/gearvrf/arpet/PlaneHandler.java#L107

and then commenting the lines starting here:

https://github.com/sidia-dev-team/GearVRf-Demos/blob/73303d58f89212681f3f1778cb0c496cda3d7de5/gvr-arpet/app/src/main/java/org/gearvrf/arpet/PlaneHandler.java#L111

[crbozz]

I also created a simpler application to demonstrate the problem:

https://github.com/crbozz/TransformTest

[liaxim]

It does look to be row-vector vs column-vector issue. Please check #1969.

[crbozz]

I tested your fix and it worked fine!

[liaxim]

Fix has been merged