Skip to content
This repository has been archived by the owner on Dec 28, 2023. It is now read-only.

System.Environment.NewLine should insert a new line everywhere possible #325

Closed
axa88 opened this issue Jun 12, 2020 · 5 comments
Closed
Labels
bug Something isn't working

Comments

@axa88
Copy link

axa88 commented Jun 12, 2020

Describe the bug
Similar to issue #250 , the System.NewLine does not work in a Toast

Toast.DisplayText($"ABC{System.Environment.NewLine}DEF", 0);

Result:
image

To Reproduce
Steps to reproduce the behavior:

  1. Create a Toast as above for example in CirclePage
  2. Observe result in screenshot

Expected behavior
System.Environment.NewLine always inserts a new line no matter where it is used.

Screenshots
see above

Environment (please complete the following information):

  • Target Product [Emulator 5.5 3.7 SDK 2.8.0.28]
  • Tizen Platform Version [Tizen 5.5]
  • Tizen.CircularUI Version [1.5.0-pre6]
@axa88 axa88 added the bug Something isn't working label Jun 12, 2020
@myroot
Copy link
Collaborator

myroot commented Jun 12, 2020

I recommend to use <br> instead of newline

@axa88
Copy link
Author

axa88 commented Jun 12, 2020

I recommend to use <br> instead of newline

This is what I have been doing until I found a dependancy using newline. I can't change this.
I would need to search and replace which is not optimal.

@myroot
Copy link
Collaborator

myroot commented Jun 12, 2020

Basically, Text of toast support a simple html tag.
So, I think we do better to use tag instead of newline .

App developer also can change Text color with tag like below
"<span color=red>Toast</span><br>",

@myroot myroot closed this as completed Jun 12, 2020
@myroot
Copy link
Collaborator

myroot commented Jun 12, 2020

It is not Bug, but a kind of API design and policy and we can decide which policy was used.

@axa88
Copy link
Author

axa88 commented Jun 12, 2020

Ok. Perhaps you have valid reasoning, which I don't see.
Some view use standard .net text, some view does not.
Ultimately I will need to develop custom translation layer just for toast. This seems to me inconsistent

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants