Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose the API implemented for the Tizen service app to the template #1620

Merged
merged 1 commit into from May 3, 2018

Conversation

hs0225
Copy link
Contributor

@hs0225 hs0225 commented May 3, 2018

IoT.js-DCO-1.0-Signed-off-by: Hosung Kim hs852.kim@samsung.com

@@ -14,7 +14,7 @@
*/

#include "iotjs.h"
#include "iotjs_module_tizen.h"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sample assumes that an include path containing iotjs_tizen_service_app.h is set in compile time. So we can use iotjs_tizen_service_app.h.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed it.

IoT.js-DCO-1.0-Signed-off-by: Hosung Kim hs852.kim@samsung.com
Copy link
Member

@daeyeon daeyeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@zherczeg zherczeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yichoi yichoi merged commit 5ddd769 into jerryscript-project:master May 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants