Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jest test for testing class - Task, add and remove functions #12

Merged
merged 4 commits into from Jun 9, 2022

Conversation

Sanja969
Copy link
Owner

@Sanja969 Sanja969 commented Jun 9, 2022

Jest test for testing class - Task, add, and remove functions

  • installed babel plug to transform all ES6 modules into CommonJS notation
  • created mocks folder and add imitating file for addTaksUI
  • installed "jsdom" environment and add created jest.config.js to set that environment
  • created tasks.test.js file for testing
  • tested if created object from class Task is with desired properties
  • tested if add function adding task on the list and on the fake HTML
  • tested if the remove function removes tasks from the list and from fake HTML
  • Mocked a storage object to "imitate" localStorage operations

Copy link

@Meltrust Meltrust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Sanja969,

Wow, you did it 🎉

Brilliant

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

To highlight

  • Add and remove tests are present✔️
  • Mocks are present✔️
  • Tests are passing✔️

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@Sanja969 Sanja969 merged commit 811d1c5 into main Jun 9, 2022
@Sanja969 Sanja969 deleted the test-add-remove branch June 9, 2022 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants