Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarifying question about the model architecture #5

Closed
e-spaulding opened this issue Jun 13, 2022 · 2 comments
Closed

Clarifying question about the model architecture #5

e-spaulding opened this issue Jun 13, 2022 · 2 comments

Comments

@e-spaulding
Copy link

Hello,

I would like to clarify the model architecture being used here. I thought this code performed predicate identification, predicate sense disambiguation, argument identification and argument classification in a single forward pass, but it looks like the "forward" function takes the indices of the predicate already identified as input. ie, see line 94 of srl/models/model.py.

I was hoping to emulate this model architecture for a similar task, but can't figure out how you go about predicate identification. Is the predicate identified before you encode and decode the sense and predicate-argument representations? If so, how?

Many thanks

@andreabac3
Copy link
Contributor

Hi @e-spaulding,

what we wrote is correct, the network in a single forward pass performs both predicate identification/disambiguation and role classification.

As input, the network can receive the identified predicates because that's how the CoNLL-2009 task is defined.
All systems in the CoNLL benchmark are trained using pre-identified predicates as input.
Instead, we let the network learn to do predicate identification in a multi-task fashion, so we have a loss for predicate identification.

Kind regards,
Andrea Bacciu

@e-spaulding
Copy link
Author

Thank you, this is very helpful!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants