Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Drifty does not show progress bar and errors encountered while downloading youtube videos. #125

Closed
poshi1865 opened this issue Oct 17, 2022 · 21 comments · Fixed by #143
Assignees
Labels
App 💻 Issues/Pull Requests which update Drifty Application Code bug 🐛 Issues/Pull Requests reporting/fixing a bug hacktoberfest Issues/Pull Requests for Hacktoberfest
Milestone

Comments

@poshi1865
Copy link
Contributor

poshi1865 commented Oct 17, 2022

Describe the bug

The errors that yt-dlp prints in it's console are not printed by Drifty. For example, while downloading a private YouTube video, yt-dlp shows this error:
ERROR: [youtube] JGXK_99nc5s: Private video. Sign in if you've been granted access to this video

Drifty does not show this.

Steps To Reproduce

  1. Run Drifty
  2. Paste the link for a private youtube video and try to download
  3. No error message shown.

Expected Behavior

Expected output is an error message

Operating System

Linux

Application Version

v1.2.0

Screenshots

No response

Additional information

No response

@poshi1865 poshi1865 added the bug 🐛 Issues/Pull Requests reporting/fixing a bug label Oct 17, 2022
@poshi1865
Copy link
Contributor Author

@SaptarshiSarkar12 Could I please be assigned to this?

@SaptarshiSarkar12
Copy link
Owner

@SaptarshiSarkar12 Could I please be assigned to this?

Yes @poshi1865 . Please link this issue to your PR.

@SaptarshiSarkar12 SaptarshiSarkar12 added the hacktoberfest Issues/Pull Requests for Hacktoberfest label Oct 17, 2022
@poshi1865
Copy link
Contributor Author

poshi1865 commented Oct 17, 2022

@SaptarshiSarkar12 I noticed that the progress bar does not show when ytdlp downloads a video. I only see Downloading....
Is this intentional, or a bug?

@SaptarshiSarkar12
Copy link
Owner

@SaptarshiSarkar12 I noticed that the progress bar does not show when ytdlp downloads a video. I only see Downloading.... Is this intentional, or a bug?

@poshi1865 Please attach a screenshot along with the inputs you have provided which has led to the error.

@poshi1865
Copy link
Contributor Author

Drifty bug

@poshi1865
Copy link
Contributor Author

Drifty bug

@SaptarshiSarkar12 This is what I was talking about

@SaptarshiSarkar12
Copy link
Owner

Drifty bug

@SaptarshiSarkar12 This is what I was talking about

@poshi1865 Yes, then it's surely a bug. Please open an issue and you may comment there if you want to work on that.
Thanks for reporting !

@SaptarshiSarkar12
Copy link
Owner

Drifty bug

@SaptarshiSarkar12 This is what I was talking about

@poshi1865 Yes, then it's surely a bug. Please open an issue and you may comment there if you want to work on that. Thanks for reporting !

Or you may make those changes through the same PR linked to this issue, just modify the description of this issue accordingly.

@poshi1865 poshi1865 changed the title [BUG] Drifty does not print errors encountered while downloading youtube videos. [BUG] Drifty does not show progress bar and errors encountered while downloading youtube videos. Oct 19, 2022
@poshi1865
Copy link
Contributor Author

Drifty bug

@SaptarshiSarkar12 This is what I was talking about

@poshi1865 Yes, then it's surely a bug. Please open an issue and you may comment there if you want to work on that. Thanks for reporting !

Or you may make those changes through the same PR linked to this issue, just modify the description of this issue accordingly.

Yeah I just did this, will make a pr soon.

@SaptarshiSarkar12
Copy link
Owner

Great @poshi1865!

@poshi1865
Copy link
Contributor Author

drifty_fix.mp4

@SaptarshiSarkar12 does this look Ok?

@SaptarshiSarkar12
Copy link
Owner

drifty_fix.mp4
@SaptarshiSarkar12 does this look Ok?

@poshi1865 Please send the jar. I need to check it once after converting it into exe file.

@poshi1865
Copy link
Contributor Author

@SaptarshiSarkar12 where do I send it?

@poshi1865
Copy link
Contributor Author

@SaptarshiSarkar12 I have mailed you a gdrive link to the jar file

@SaptarshiSarkar12
Copy link
Owner

@SaptarshiSarkar12 I have mailed you a gdrive link to the jar file

ok @poshi1865 shall check it and let you know if it works.

@poshi1865
Copy link
Contributor Author

@SaptarshiSarkar12 Hi! Any update?

@SaptarshiSarkar12
Copy link
Owner

@SaptarshiSarkar12 Hi! Any update?

Not checked due to repair of my laptop. @poshi1865

@SaptarshiSarkar12
Copy link
Owner

Shall inform you @poshi1865 😄

@SaptarshiSarkar12
Copy link
Owner

@SaptarshiSarkar12 Hi! Any update?

Yes @poshi1865 it works successfully on my pc. You may open a PR.

@poshi1865
Copy link
Contributor Author

@SaptarshiSarkar12 Done! Please review and let me know. Thanks!

@SaptarshiSarkar12
Copy link
Owner

@SaptarshiSarkar12 Done! Please review and let me know. Thanks!

Reviewed #143 @poshi1865 ! 👍

@SaptarshiSarkar12 SaptarshiSarkar12 added the App 💻 Issues/Pull Requests which update Drifty Application Code label Mar 20, 2023
@SaptarshiSarkar12 SaptarshiSarkar12 added this to the Drifty v1.2.1 milestone Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
App 💻 Issues/Pull Requests which update Drifty Application Code bug 🐛 Issues/Pull Requests reporting/fixing a bug hacktoberfest Issues/Pull Requests for Hacktoberfest
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants