Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Report] F-Droid can't build #395

Closed
licaon-kter opened this issue Jul 7, 2023 · 4 comments
Closed

[Bug Report] F-Droid can't build #395

licaon-kter opened this issue Jul 7, 2023 · 4 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@licaon-kter
Copy link

licaon-kter commented Jul 7, 2023

Since versionCode is not static anymore newer versions were not picked up automatically.

Is there a reason to have different versionCodes for/from the same code built at a different hour?

Now, first issue, Sentry key missing when trying to build 4.0.0:

> Task :app:uploadSentryProguardMappingsRelease FAILED
> compressing mappings
> uploading mappings
error: An organization slug is required (provide with --org)

Add --log-level=[info|debug] or export SENTRY_LOG_LEVEL=[info|debug] to see more output.
Please attach the full debug log to all bug reports.

> Task :app:l8DexDesugarLibRelease

0 problems were found storing the configuration cache.

See the complete report at file:///home/vagrant/build/com.sapuseven.untis/build/reports/configuration-cache/ga1mgi17vi7qah3znxmjbdwu/8d0xuk5dr9dl1afa8wj7ogmir/configuration-cache-report.html

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':app:uploadSentryProguardMappingsRelease'.
> Process 'command '/tmp/.sentry-cli10692983813887660774.exe'' finished with non-zero exit value 1

Second issue, 4.0.1 can't even be tried since mlkit is not FOSS: 0f336a5

@licaon-kter licaon-kter added the bug Something isn't working label Jul 7, 2023
@SapuSeven
Copy link
Owner

Previously, the version code changed manually with each new released version.
However, when developing the Material 3 Update, I added the ability to test early versions using a Private Testing Track on Google Play.
This needed a new release published to Google Play for each build. But those builds would have used the same version code. This didn't work for Google Play where each release needed to have a new version code.
I also couldn't run a separate version numbering track because version codes need to always be ascending.
For those reasons, I decided to update the version code to be calculated based on build time. That way, each build will always have a new, higher version code.

I will look into the issues with F-Droid builds.
With regards to the ml-kit dependency, I will try to find a solution, because it is not strictly required (There's a very simple backup scanner).
BTW The reason for switching the code scanner is that the originally used library for that had some publishing issues and couldn't be downloaded on build time.

@SapuSeven
Copy link
Owner

Thing is, I'm not an F-Droid user and I don't really know how to correctly configure everything.

I created a new branch, fdroid - It adds two flavors: gms and foss. The foss flavor doesn't include the GMS dependencies.

As for the mapping upload issue (from stack trace): This would be resolved by excluding the corresponding Gradle task like this: -x uploadSentryProguardMappingsRelease

I'd greatly appreciate the help of anyone who knows how to correctly setup the F-Droid metadata file to handle these changes and also the dynamic version code.

@SapuSeven SapuSeven added the help wanted Extra attention is needed label Jul 9, 2023
@SapuSeven SapuSeven pinned this issue Aug 5, 2023
@SapuSeven
Copy link
Owner

https://gitlab.com/fdroid/fdroiddata/-/merge_requests/13652
F-Droid metadata update has been submitted.
The F-Droid store should receive the 4.x updates soon.

@SapuSeven
Copy link
Owner

Merged 🎉

@SapuSeven SapuSeven unpinned this issue Sep 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants