Disable name check #574
Merged
Disable name check #574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: there is a branch in SasView that contains the appropriate changes in parameters |
|
Ouch .. if it breaks things "pretty hard" should we instead be reverting that merge? Adding @pkienzle to the reviewer list since it is apparently his PR that broke things? |
|
It's not so bad, but can add Paul of you like
…On Sun, 6 Aug 2023, 20:45 Paul Butler, ***@***.***> wrote:
Ouch .. if it breaks things "pretty hard" should we instead be reverting
that merge? Adding @pkienzle <https://github.com/pkienzle> to the
reviewer list since it is apparently his PR that broke things?
—
Reply to this email directly, view it on GitHub
<#574 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACKU4SVG27LRTHZKQVNGFATXT7X65ANCNFSM6AAAAAA3EUOTNE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
wpotrzebowski
approved these changes
Aug 7, 2023
|
Yeah, although this check didn't exist before, so I think it will do for
now until we figure out how it should be.
…On Mon, Aug 7, 2023 at 8:29 AM Wojciech Potrzebowski < ***@***.***> wrote:
***@***.**** approved this pull request.
It seems quite dangerous but it seems to work (at least I haven't
discovered any serious issues while performing functionality tests).
Orientantion viewer seems to work again in (at least in my local branch).
—
Reply to this email directly, view it on GitHub
<#574 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACKU4SVRRAEMF36PKRK7BHTXUCKNHANCNFSM6AAAAAA3EUOTNE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
--
Dr Lucas Wilkins
+44 (0) 7505 915 726
Personal Website: http://www.lucaswilkins.com/
Alternate e-mail: ***@***.***
|
|
so should we make sure then to reopen #573 once this is merged and add comment that this tourniquet stops the bleeding but it still needs proper fixing? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixed #573 and SasView/sasview#2577
It's probably not the optimal fix, but it works, and can be used until something better comes along.