Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix race condition for creating SAS_DLL_PATH, redo of PR #520 #537

Merged
merged 1 commit into from Nov 15, 2022

Conversation

bmaranville
Copy link
Contributor

A clean re-implementation of the fix in #520 on the current master (underlying function was changed in another commit)

@llimeht
Copy link
Contributor

llimeht commented Nov 9, 2022

Note that there's a similar location which also could be racy in sasmodels/core.py:precompile_dlls L362. The same fix is sufficient. It's also unlikely to get hit, but possibly still feasible when making sasmodels documentation with make -j4 for instance.

@wpotrzebowski wpotrzebowski merged commit 8f25401 into SasView:master Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants