Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support custom data names in plot legends #2293

Merged

Conversation

pbeaucage
Copy link
Contributor

Fixes #2253 by switching Plotter to use data.name as the default label for a plot item rather than data._title. data.name changes with the "Change Name" option in the Data Explorer.

@pbeaucage pbeaucage linked an issue Oct 27, 2022 that may be closed by this pull request
Copy link
Member

@rozyczko rozyczko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I swear we went through these changes (name->title, title->name) a few times already, with every change breaking something somewhere...
I don't think we targeted the legends though, so I'd say it's kosher.

Code looks good.

@lucas-wilkins lucas-wilkins merged commit fd7a803 into main Oct 27, 2022
@pkienzle pkienzle deleted the 2253-custom-data-names-are-not-displayed-in-legend branch November 4, 2022 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom data names are not displayed in legend
3 participants