Source excerpt breaks on semicolon inside variable #191

Closed
jsit opened this Issue Aug 27, 2014 · 6 comments

Comments

Projects
None yet
5 participants
@jsit

jsit commented Aug 27, 2014

I have a variable defined as a string with a semicolon in it; this causes the excerpt/preview of the source code to be truncated at that semicolon.

@pascalduez

This comment has been minimized.

Show comment
Hide comment
@pascalduez

pascalduez Aug 27, 2014

Member

Would you mind providing and example ?

Member

pascalduez commented Aug 27, 2014

Would you mind providing and example ?

@jsit

This comment has been minimized.

Show comment
Hide comment
@jsit

jsit Aug 27, 2014

$string: url('data:image/svg+xml;base64,asdfasdf');

jsit commented Aug 27, 2014

$string: url('data:image/svg+xml;base64,asdfasdf');

@pascalduez

This comment has been minimized.

Show comment
Hide comment
Member

pascalduez commented Aug 27, 2014

Confirmed.
Moved to SassDoc/scss-comment-parser#15

@pascalduez pascalduez added the Bug label Aug 27, 2014

@HugoGiraudel HugoGiraudel added this to the 1.6 milestone Aug 27, 2014

@valeriangalliat

This comment has been minimized.

Show comment
Hide comment
@valeriangalliat

valeriangalliat Aug 29, 2014

Member

Fixed in scss-comment-parser.

Member

valeriangalliat commented Aug 29, 2014

Fixed in scss-comment-parser.

@HugoGiraudel

This comment has been minimized.

Show comment
Hide comment
@HugoGiraudel

HugoGiraudel Aug 29, 2014

Member

Please run rm -rf node_modules && npm install.

Member

HugoGiraudel commented Aug 29, 2014

Please run rm -rf node_modules && npm install.

@valeriangalliat

This comment has been minimized.

Show comment
Hide comment
@valeriangalliat

valeriangalliat Aug 29, 2014

Member

(npm update should be enough.)

Member

valeriangalliat commented Aug 29, 2014

(npm update should be enough.)

@jgerigmeyer jgerigmeyer referenced this issue in SassDoc/scss-comment-parser Jan 31, 2018

Closed

Semicolon inside variable content breaks parser. #37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment